Add View Argument to Window.run() #2468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was about to tag you in this issue, but you beat me :) |
|
Haha, I was looking through the issues and it definitely seemed like a good place to start! Just joined the discord and am excited to contribute more |
einarf
requested changes
Dec 5, 2024
einarf
reviewed
Dec 5, 2024
|
On it! I only ran make.py lint and make.py test, I'll make sure to read the contributing doc more thoroughly |
einarf
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2400
I was looking at the Good First Issue tag and I found this one! Most of the work was already done in #2450 but that pr seems to have been abandoned, so I just applied the requested changes in here.
Please let me know if there's any issues :). This seems like a wonderful repo that I'd love to contribute to.